Results 1 to 8 of 8

Thread: Feature Request: >= and <= operators in filter function box

  1. #1
    Tuner in Training
    Join Date
    Jul 2023
    Posts
    14

    Lightbulb Feature Request: >= and <= operators in filter function box

    As far as I am aware, for an unexplained reason, "greater than or equal to" and "less than or equal to" are two operators that are not supported in the filter function formula. In all the software development I've done in my 20 year career every system has supported the 6 basic operators and 3 logical operators.

    > Greater than
    < Less than
    >= Greater than or equal
    <= Less than or equal
    != Not equal
    == Equal

    It does support logical operators such as AND and OR but curiously not NOT.
    It would be nice if HP Tuners also implemented the standard logical operators

    && AND
    || OR
    ! NOT

    The reason for the need should be self-explanatory but I will provide a typical situation. Suppose you wish to graph a variable in a certain region you would add a filter function of [var]>5 and [var]<10. And in another graph you want to graph that variable [var]>=10 and [var]<15. This provides full coverage, however the greater than or equal conditional operator doesn't exist, so if you use [var]>10 then you have actually skipped over all values that are equal to 10.

    Thank you for this consideration

  2. #2
    Senior Tuner
    Join Date
    Jul 2020
    Location
    VIC Australia
    Posts
    1,158
    And to expose the enum index so flags can be included in the filter.

  3. #3
    HP Tuners Owner Keith@HPTuners's Avatar
    Join Date
    Sep 2002
    Location
    Chicago, IL
    Posts
    6,395
    I just looked into this.

    There's no quick and easy way to add >=, etc.. but we can add it to the list. I agree these basics should be supported.

    For now I think you should be able to do (left > right OR left = right) for >=.
    We got this guy Not Sure, ...

  4. #4
    Tuning Addict
    Join Date
    Jan 2015
    Location
    Franklin, NC / Gainesville, Ga
    Posts
    6,804
    Quote Originally Posted by Keith@HPTuners View Post
    I just looked into this.

    There's no quick and easy way to add >=, etc.. but we can add it to the list. I agree these basics should be supported.

    For now I think you should be able to do (left > right OR left = right) for >=.
    Yes, but then the formulas start getting really long and the scanner REALLY starts to bog. Just this formula -

    " ABS([50040.71]-[50040.71.shift(-10)]) < ([50040.71]/[50040.71.shift(-10)])*0.1 & ABS([2311.71]-[2311.71.shift(-10)]) < ([2311.71]/[2311.71.shift(-10)])*0.1 OR [50090.156] > 95 "

    being used in a couple of locations is enough to just about kill it so once you start adding in this -

    " [14.161] > 25 and [14.161] < 35 and [2172.161] > 4 and [2172.161] < 11 "

    plus the other part, well it literally takes 5 minutes sometimes to open 20 or 30 minute logs. Then you might as well forget other functions.
    2010 Vette Stock Bottom LS3 - LS2 APS Twin Turbo Kit, Trick Flow Heads and Custom Cam - 12psi - 714rwhp and 820rwtq / 100hp Nitrous Shot starting at 3000 rpms - 948rwhp and 1044rwtq still on 93
    2011 Vette Cam Only Internal Mod in stock LS3 -- YSI @ 18psi - 811rwhp on 93 / 926rwhp on E60 & 1008rwhp with a 50 shot of nitrous all through a 6L80

    ~Greg Huggins~
    Remote Tuning Available at gh[email protected]
    Mobile Tuning Available for North Georgia and WNC

  5. #5
    HP Tuners Owner Keith@HPTuners's Avatar
    Join Date
    Sep 2002
    Location
    Chicago, IL
    Posts
    6,395
    How would the equations you listed be improved with new operators?

    The big CPU sinks you have are ABS and the .shift(). I can look into seeing if parts of the expression are being calculated multiple times. IE: You have 50040.71.shift(-10) listed twice, but it should only need to be calculated once per function evaluation.

    Also, can you explain what this expression does in more detail?
    " ABS([50040.71]-[50040.71.shift(-10)]) < ([50040.71]/[50040.71.shift(-10)])*0.1 & ABS([2311.71]-[2311.71.shift(-10)]) < ([2311.71]/[2311.71.shift(-10)])*0.1 OR [50090.156] > 95 "

    You might be able to take advantage of the slope() function.

    Please submit a ticket with a log that takes a long time to open. Please include a layout that opens the log fast, and a layout that opens the log slow.

    Thanks!
    We got this guy Not Sure, ...

  6. #6
    Tuner in Training
    Join Date
    Jul 2023
    Posts
    14
    Thanks Keith you're the best!

  7. #7
    Advanced Tuner Cringer's Avatar
    Join Date
    Aug 2021
    Location
    Somewhere smoothing your VVE table
    Posts
    515
    I am really hoping this feature request gets added.
    A standard approach will give you standard results.

    My Tuning Software:

    VVE Assistant [update for v1.5]
    MAF Assistant
    EOIT Assistant

  8. #8
    Can you elaborate on the specific challenges you face with the current formula limitations and how the suggested operators would significantly improve your tuning process?